Re: [hackers] [quark][PATCH 2/3] permit prefix to be empty in -v format string

From: Laslo Hunhold <dev_AT_frign.de>
Date: Mon, 2 Apr 2018 09:59:43 +0200

On Mon, 2 Apr 2018 02:55:00 +0200
Josuah Demangeon <mail_AT_josuah.net> wrote:

Dear Josuah,

> The previous parsing of the -v vhosts made sure there were 4 tokens.
> If there was no prefix specified, usage() is called. Now, it only
> checks for the firsts 3, with .prefix set to null if there are only
> 3 tokens.

this is a very nice find. To be honest, both the -m and -v options were
just roughly implemented and I just didn't have the time to get back to
them and test them. This is also the case here, where I admittedly fell
victim to a copy pasto from the -m-option-parsing.

Thanks for your patch! I applied it with an additional modification to
the manpage explicitly marking the prefix as optional.

With best regards

Laslo Hunhold

-- 
Laslo Hunhold <dev_AT_frign.de>
Received on Mon Apr 02 2018 - 09:59:43 CEST

This archive was generated by hypermail 2.3.0 : Mon Apr 02 2018 - 10:00:26 CEST