Re: [hackers] [PATCH] [dwm] Make unset property fallback strings configurable

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Tue, 3 Apr 2018 19:55:53 +0200

Hi Eric

On Mon, Apr 02, 2018 at 08:59:57PM -0700, Eric Pruitt wrote:
> On Mon, Apr 02, 2018 at 11:10:42AM +0200, Silvan Jegen wrote:
> > error: git diff header lacks filename information when removing 1
> > leading pathname component (line 5)
>
> Please try the attached patch.

I tried the attached patch and it didn't work either. After creating
a patch in this repo myself (and googling the error) I realized that
your patch didn't have the "a/", resp. "b/" string prefix in the diff
filenames. After adding these prefixes by hand (attached), the patch
applied for me.

How did you generate these patches? It's the first time I had this issue.

Anyways, I compiled the code and the code looks correct to me. I never
encountered this issue myself so I am not sure if this patch is really
needed or not. If it solves a real issue people are having, applying it
makes sense.


Cheers,

Silvan

Received on Tue Apr 03 2018 - 19:55:53 CEST