Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

From: Michael Forney <mforney_AT_mforney.org>
Date: Mon, 1 Oct 2018 18:35:13 -0700

On 2018-10-01, David Phillips <david_AT_sighup.nz> wrote:
> Hi,
>
> Bumping this patch since sbase master now fails to build against
> glibc 2.28
>
> Let me know if there are any improvements that could be made.
>
> Thanks,
> David

I wish the #ifdef wasn't necessary, but it seems like the only way to
use major/minor on glibc and non-glibc systems.

As far as I can tell, glibc has had sys/sysmacros.h for a long time,
so it should be okay to always include it when __GLIBC__ is defined.

Rather than the if-else, I think we should always include sys/types.h,
and also sys/sysmacros.h on glibc. I also think the comment is
unnecessary. Do you mind if I apply with those two changes?
Received on Tue Oct 02 2018 - 03:35:13 CEST