Re: [hackers] [PATCH] [sbase] ls: allow listing contents of directories with +r-x

From: David Phillips <david_AT_sighup.nz>
Date: Tue, 2 Oct 2018 15:32:12 +1300

On Tue, Sep 25, 2018 at 06:48:08PM -0700, Michael Forney wrote:
>
> Rather than keeping track of the full prefix for `mkent` and `output`,
> what do you think about just tracking the directory fd, and using the
> *at family of functions to work relative to that directory? I attached
> a patch to show what I'm thinking. It looks like this might even
> simplify some of the code.
>

I just read your patch in full and it looks good to me. It seems to
describe and exhibit the desired behaviour. One minor thing I would
propose adding is changing the stat error message to display the full
path rather than just the name of the file/directory that cannot be
stat-ed. This clarifies the source of errors in the case of `ls -R`-
style commands.

Regarding the stat failure, please find a patch attached based on your
patch which allows stat failure.

Thanks,
David

Received on Tue Oct 02 2018 - 04:32:12 CEST