Re: [hackers] [PATCH] [sbase] ls: allow listing contents of directories with +r-x

From: Michael Forney <>
Date: Tue, 25 Sep 2018 18:48:08 -0700

On 2018-07-08, David Phillips <> wrote:
> As a side note to this patch: it's been sitting in my queue for
> the better part of a year while I internally debated the
> untidiness of not being allowed to chdir. It's an unfortunate
> result of implementing this behaviour, but it's behaviour
> that other implementations (namely GNU, but not Solaris) support.
> Let me know any feedback or oversights on my part,
> David

Hi David,

Rather than keeping track of the full prefix for `mkent` and `output`,
what do you think about just tracking the directory fd, and using the
*at family of functions to work relative to that directory? I attached
a patch to show what I'm thinking. It looks like this might even
simplify some of the code.

Either way, I think the changes to avoid chdir and to show unknown
entries (stat failure) should be separate commits.

Received on Wed Sep 26 2018 - 03:48:08 CEST

This archive was generated by hypermail 2.3.0 : Wed Sep 26 2018 - 03:48:23 CEST