Re: [hackers] [PATCH] [sbase] ls: allow listing contents of directories with +r-x

From: David Phillips <>
Date: Wed, 26 Sep 2018 18:59:13 +1200

On Tue, Sep 25, 2018 at 06:48:08PM -0700, Michael Forney wrote:
> Hi David,

Hi there

> Rather than keeping track of the full prefix for `mkent` and `output`,
> what do you think about just tracking the directory fd, and using the
> *at family of functions to work relative to that directory? I attached
> a patch to show what I'm thinking. It looks like this might even
> simplify some of the code.

Looks better to me. I always felt that there was something wrong with
but wasn't aware of the solution you have now presented. Thanks for
looking at the patch. I will more thoroughly read and understand your
patch soon.

> Either way, I think the changes to avoid chdir and to show unknown
> entries (stat failure) should be separate commits.

Agreed. Not sure why they ended up in the same patch here aside from
human error.

Received on Wed Sep 26 2018 - 08:59:13 CEST

This archive was generated by hypermail 2.3.0 : Wed Sep 26 2018 - 09:00:26 CEST