Re: [hackers] [st][PATCH] separate blinking timer from drawing in run()

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Wed, 02 Jan 2019 19:47:39 +0100

Hi

[2019-01-02 02:50] kais euchi <kais.euchi_AT_gmail.com>
> This article [?] made me wonder how to improve latency in st, and i
> thought i would share this small modification for a non-blinking setup.
> When blinktimeout is set to 0, it reduces latency by ca. 5ms [?] by avoiding
> useless delay calculation making it also independent from the xfps setting.

I measured the difference on my machine (dwm on a Ryzen 7 1700X) and it
was quite a bit bigger:

# Title Min Max Avg SD
1 st normal without blinking 20.0 29.6 22.7 3.0
2 vim in st without blinking 20.1 29.5 21.8 1.1
3 st-patched normal without blinking 3.9 12.8 7.8 1.9
4 vim in st-patched without blinking 4.9 12.3 8.6 1.3

where "st normal" is just st running bash. It's somewhat suspect that
in the non-patched case the average latency of st running vim is lower
than with just bash. For now I will assume it was a statistical fluke.

All datapoints generated by typometer can be downloaded from here[0].

Not sure the difference is actually notable in practice but the average
latency is reduced to less than half on my machine. Looks nice! It comes
at a cost of a few more lines of code though.


Cheers,

Silvan

[0] https://sillymon.ch/data/resultspatchedandunpatched.csv
Received on Wed Jan 02 2019 - 19:47:39 CET

This archive was generated by hypermail 2.3.0 : Wed Jan 02 2019 - 19:48:24 CET