Re: [hackers] [st][PATCH] Let the user specify CPPFLAGS

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Thu, 10 Jan 2019 18:21:36 +0100

On Thu, Jan 10, 2019 at 01:36:09PM +0100, Paride Legovini wrote:
> This complements the work done in d4928ed, allowing the user to specify
> the preprocessor flags with the CPPFLAGS environment variable. This is
> useful for example to specify preprocessor macros with -D.
>
> CFLAGS could be used instead, but CPPFLAGS is more correct and is expected
> to be honored in some cases. For example, the helper scripts to build
> Debian packages make use of CPPFLAGS, but the variable is currently
> being ignored unless manually appended to CFLAGS.
> ---
> config.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index 64a1da9..5059632 100644
> --- a/config.mk
> +++ b/config.mk
> _AT_@ -21,8 +21,8 @@ LIBS = -L$(X11LIB) -lm -lrt -lX11 -lutil -lXft \
> `$(PKG_CONFIG) --libs freetype2`
>
> # flags
> -CPPFLAGS = -DVERSION=\"$(VERSION)\" -D_XOPEN_SOURCE=600
> -STCFLAGS = $(INCS) $(CPPFLAGS) $(CFLAGS)
> +STCPPFLAGS = -DVERSION=\"$(VERSION)\" -D_XOPEN_SOURCE=600
> +STCFLAGS = $(INCS) $(STCPPFLAGS) $(CPPFLAGS) $(CFLAGS)
> STLDFLAGS = $(LIBS) $(LDFLAGS)
>
> # OpenBSD:
> --
> 2.20.1
>
>

Applied, thanks for the patch!

-- 
Kind regards,
Hiltjo
Received on Thu Jan 10 2019 - 18:21:36 CET

This archive was generated by hypermail 2.3.0 : Thu Jan 10 2019 - 18:24:21 CET