[hackers] [quark] Don't replace '+' with ' ' when decoding URLs || Laslo Hunhold

From: <git_AT_suckless.org>
Date: Thu, 10 Jan 2019 22:07:59 +0100 (CET)

commit e299e186edba03192fc12f6709df48d02aa83849
Author: Laslo Hunhold <dev_AT_frign.de>
AuthorDate: Thu Jan 10 22:02:23 2019 +0100
Commit: Laslo Hunhold <dev_AT_frign.de>
CommitDate: Thu Jan 10 22:02:23 2019 +0100

    Don't replace '+' with ' ' when decoding URLs
    
    After the initial report by Platon Ryzhikov, I couldn't validate this
    behaviour with the given RFC 3986[0], which only speaks of percent encoding
    for reserved characters.
    
    [0]:https://tools.ietf.org/html/rfc3986
    
    Signed-off-by: Laslo Hunhold <dev_AT_frign.de>

diff --git a/http.c b/http.c
index c848e81..673e6eb 100644
--- a/http.c
+++ b/http.c
_AT_@ -80,9 +80,7 @@ decode(char src[PATH_MAX], char dest[PATH_MAX])
         char *s;
 
         for (s = src, i = 0; *s; s++, i++) {
- if (*s == '+') {
- dest[i] = ' ';
- } else if (*s == '%' && (sscanf(s + 1, "%2hhx", &n) == 1)) {
+ if (*s == '%' && (sscanf(s + 1, "%2hhx", &n) == 1)) {
                         dest[i] = n;
                         s += 2;
                 } else {
Received on Thu Jan 10 2019 - 22:07:59 CET