Re: [hackers] [dmenu] fix crash when XOpenIM returns NULL || Hiltjo Posthuma

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Tue, 12 Feb 2019 21:48:51 +0100

Hi Anselm

[2019-02-12 11:32] Anselm Garbe <garbeam_AT_gmail.com>
> This is so ugly. People should learn English instead of using
> antiquated text input methods ;)

I also think this code is very ugly and should be simplified like in
the patches that have been sent before for this issue. Something like
(untested):

+ /* input methods */
+ if ((xim = XOpenIM(dpy, NULL, NULL, NULL)) == NULL) {
+ XSetLocaleModifiers("_AT_im=local");
+ xim = XOpenIM(dpy, NULL, NULL, NULL);
+ }

That is still ugly but better at least.


> Suckless is also about the input interface. If a typographic system
> sucks, because it consists of thousands of letters, it has to be
> fixed.

Yeahh, here I obviously can't agree...


Cheers,

Silvan
Received on Tue Feb 12 2019 - 21:48:51 CET