On Wed, Jun 26, 2019 at 11:32:23AM -0700, Michael Forney wrote:
> On 2019-06-26, Richard Ipsum <richardipsum_AT_fastmail.co.uk> wrote:
> > On Tue, Jun 25, 2019 at 04:55:10PM -0700, Michael Forney wrote:
[snip]
>
> >> I think this is unintended, since there appears to be some logic to
> >> save and restore errno in grscan(). Looks like it was introduced in
> >> https://github.com/openbsd/src/commit/b971f1acd7c34a49359ccefbe512e06f3826a939
> >> (first released in OpenBSD 5.9).
> >
> > Right, exactly. I think the reason this doesn't break OpenBSD chown is
> > because it uses `gid_from_group` and the implementation[1] for that
> > actually ignores errno, if it didn't they might have spotted this issue
> > themselves.
> >
> > Do you want to raise this with upstream or shall I?
>
> If you don't mind, I'd appreciate it if you did.
A fix for this has been applied to OpenBSD's libc.
Thanks,
Richard
Received on Wed Jul 03 2019 - 18:42:13 CEST