Re: [hackers] [dwm][PATCH] cleanup, saves 7 LOC

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Tue, 24 Dec 2019 11:36:35 +0100

> As of [0], the Xorg man page for XFree reads:
>
> "If data is NULL, no operation is performed."
>
> It was changed to reflect the behavior that Xorg has always had.
> XFree() has been #defined to free() since their initial code import in
> 2003. However, it looks like other documentation was not updated, and
> it's understandable if you want to keep the NULL checks.
>
> [0]: https://gitlab.freedesktop.org/xorg/lib/libx11/commit/78851f6

Agreed.

> > I think the current sendevent() code is more readable.

Agreed too.

Please provide both changes as separate commits, one for XFree()
unconditional call, and another one for refactoring sendevent().

Thanks!
Received on Tue Dec 24 2019 - 11:36:35 CET

This archive was generated by hypermail 2.3.0 : Tue Dec 24 2019 - 11:48:21 CET