Re: [hackers] [quark][PATCH] makes host parameters optional

From: Laslo Hunhold <dev_AT_frign.de>
Date: Tue, 21 Apr 2020 17:23:00 +0200

On Mon, 13 Apr 2020 22:46:07 -0500
nihal_AT_nihaljere.xyz wrote:

Dear Nihal,

> For me at least, the first valid configuration found by getaddrinfo
> works fine most of the time. Obviously if this isn't the configuration
> you want, you can specify the host explicitly.

the patch looks good. Thanks for submitting! I just revised the logic
expression

> /* can't have both host and UDS but must have one of port or UDS*/
> if ((s.host && udsname) || !(s.port || udsname)) {

given that, if we say that H means the host is set, U means the
UDS-name is set and P means the port is set, it holds

  (H ∧ U) ∨ ¬(P ∨ U)
↔


∧
∨
¬
↔
Received on Tue Apr 21 2020 - 17:23:00 CEST