Re: [hackers] [dwm][patch] Make EWMH windows float

From: Jakub Leszczak <>
Date: Thu, 14 May 2020 19:17:00 +0200

> (...) except that it would be better to handle this before rules get applied (...)

updatewindowtype() also handles fullscreen and runs setfullscreen().
setfullscreen() in turn sets `c->isfloating = 1`, and oldx, oldbw etc.
And so setfullscreen() cannot be moved before applyrules(), setting of
c->{x,y,bw} and configure().

This would require to extract setfullscreen() outside of
updatewindowtype(). This actually might be a good thing since
setfullscreen() is connected strictly with WMState, not WMWindowType.
And if I understand code correctly toggling fullscreen is done via
clientmessage() and not via propertynotify() -> updatewindowtype()

I am not 100% sure though if I am correct.

Jakub Leszczak

Received on Thu May 14 2020 - 19:17:00 CEST

This archive was generated by hypermail 2.3.0 : Thu May 14 2020 - 19:24:39 CEST