Re: [hackers] [libgrapheme][PATCH] Simplify cp_decode and be more strict

From: Laslo Hunhold <dev_AT_frign.de>
Date: Thu, 28 May 2020 21:52:45 +0200

On Thu, 28 May 2020 19:55:27 +0200
Mattias Andrée <maandree_AT_kth.se> wrote:

Dear Mattias,

> Looks good. But I wouldn't call the mask operation change
> and optimisation (even though it is), than I would have
> suggested `*cp = s[0] ^ lut[off].lower`. :)

there's always a tradeoff between readability and optimization. The
former is, imho, more important, because compiler optimizations have
become really good.

I was thinking about adding a special ASCII-case, as ASCII is,
obviously, the most prevalent encoding.

With best regards

Laslo
Received on Thu May 28 2020 - 21:52:45 CEST