Re: [hackers] [quark][PATCH] fix for NOT_MODIFIED being sent in non-GMT timezone

From: Laslo Hunhold <dev_AT_frign.de>
Date: Thu, 23 Jul 2020 16:38:50 +0200

On Tue, 21 Jul 2020 20:38:41 +0200
Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:

Dear Hiltjo,

> I would use timegm(). It is not in POSIX, but it does exactly the
> right thing. It should be available in glibc, musl and on all BSDs.
>
> Hacking around mktime to get the correct result has some gotcha's. I
> would not do it.
>
> The latest patch from Jeremy looks good to me.

yeah, as long as it's on musl and OpenBSD it's fine by me.

With best regards

Laslo
Received on Thu Jul 23 2020 - 16:38:50 CEST