[hackers] [dwm] Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists" || Hiltjo Posthuma

From: <git_AT_suckless.org>
Date: Tue, 26 Apr 2022 10:35:48 +0200 (CEST)

commit a4771de5ba54a38b062a7d748635f21c141b5c7e
Author: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
AuthorDate: Tue Apr 26 10:30:59 2022 +0200
Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
CommitDate: Tue Apr 26 10:30:59 2022 +0200

    Revert "manage: For isfloating/oldstate check/set, ensure trans client actually exists"
    
    This reverts commit bece862a0fc4fc18ef9065b18cd28e2032d0d975.
    
    It caused a regression, for example:
    https://lists.suckless.org/hackers/2203/18220.html

diff --git a/dwm.c b/dwm.c
index 0fc328a..823bf6b 100644
--- a/dwm.c
+++ b/dwm.c
_AT_@ -1065,7 +1065,7 @@ manage(Window w, XWindowAttributes *wa)
         XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask);
         grabbuttons(c, 0);
         if (!c->isfloating)
- c->isfloating = c->oldstate = t || c->isfixed;
+ c->isfloating = c->oldstate = trans != None || c->isfixed;
         if (c->isfloating)
                 XRaiseWindow(dpy, c->win);
         attach(c);
Received on Tue Apr 26 2022 - 10:35:48 CEST