Re: [hackers] [sent] [PATCH 1/3] sent.c: Drop unnecessary NULL checks

From: Laslo Hunhold <dev_AT_frign.de>
Date: Sun, 26 Jun 2022 23:16:32 +0200

On Sun, 26 Jun 2022 21:53:49 +0300
Greg Minshall <minshall_AT_acm.org> wrote:

Dear Greg,

> for what it's worth, i'd probably code with the checks, so as to avoid
> future code editors (including myself) doing a double-take, thinking,
> "hmm, did the author consider that case?". (though, of course, you
> did that same -- if opposite -- double-take when you saw that code.)

come on, it is general knowledge that free() accepts NULL arguments.
The extra checks just add more cruft.

With best regards

Laslo
Received on Sun Jun 26 2022 - 23:16:32 CEST