Hi Hiltjo,
> I would remove the echo also for the verbose changes.
I get the point of consistency, but I think an output as the following is more
confusing than helpful.
echo sent build options:
sent build options:
This seems to just pollute stdout with unnecessary information.
I've even played with the idea of removing all echos and just keep the ones
under the `options` target, because I don't think the others add much value.
But I'll wait for the maintainers feedback before rewriting the whole Makefile.
> I see the CFLAGS is also changed. You should document it in the commit message.
I agree.
> I'm not sure I agree with adding -Wall or the many -Woptions though.
>
> It is up to the current sent maintainer to decide.
Since most Suckless tools include a few `-W` options, NRK's suggestion
was sound to me, but that's indeed a point the maintainer has to decide.
And just for the record: `-Wall` was already there, I just added the other
`-W` options.
--
Best Regards,
Tom Schwindl
Received on Mon Jun 27 2022 - 10:00:35 CEST