Re: [hackers] [dwm][PATCH] config.mk: update to _XOPEN_SOURCE=700L

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Fri, 17 Feb 2023 15:30:49 +0100

On Fri, Feb 17, 2023 at 11:05:09AM +0600, NRK wrote:
> SA_NOCLDWAIT is marked as XSI in the posix spec [0] and freebsd seems to
> more be strict about the feature test macro [1].
>
> so update the macro to use _XOPEN_SOURCE=700L instead, which is
> equivalent to _POSIX_C_SOURCE=200809L except that it also unlocks the
> X/Open System Interfaces.
>
> [0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html#tag_13_42
> [1]: https://lists.suckless.org/dev/2302/35111.html
>
> Reported-by: beastie <pufferfish_AT_riseup.net>
> ---
> config.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config.mk b/config.mk
> index ef8acf7..ba64d3d 100644
> --- a/config.mk
> +++ b/config.mk
> _AT_@ -26,7 +26,7 @@ INCS = -I${X11INC} -I${FREETYPEINC}
> LIBS = -L${X11LIB} -lX11 ${XINERAMALIBS} ${FREETYPELIBS}
>
> # flags
> -CPPFLAGS = -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_C_SOURCE=200809L -DVERSION=\"${VERSION}\" ${XINERAMAFLAGS}
> +CPPFLAGS = -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_XOPEN_SOURCE=700L -DVERSION=\"${VERSION}\" ${XINERAMAFLAGS}
> #CFLAGS = -g -std=c99 -pedantic -Wall -O0 ${INCS} ${CPPFLAGS}
> CFLAGS = -std=c99 -pedantic -Wall -Wno-deprecated-declarations -Os ${INCS} ${CPPFLAGS}
> LDFLAGS = ${LIBS}
> --
> 2.39.1
>
>

Thanks, I pushed the patch and added a few more notes on which systems it was
tested (on my side). It also fixed compilation on NetBSD (9.3).

-- 
Kind regards,
Hiltjo
Received on Fri Feb 17 2023 - 15:30:49 CET

This archive was generated by hypermail 2.3.0 : Fri Feb 17 2023 - 15:36:38 CET