Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Mon, 30 Oct 2023 00:12:41 +0100

> > I guess that the original intent of the code here
> > was to to find any executable file.
>
> I concur. It seems to me that the default output mode for `cc` is 755
> even if the parent directory has more restrictive permissions. So the
> more concise -perm -111 should suffice. I will leave the decision up
> to Roberto though.

Well, the file creation mode for the executables is 777,
with user umask applied, so could be anything really,
like absent executable bit for others.
The install script though, once executables have been identified,
changes the target file mode to 755.

I'm not fond of that method, especially that we already know
the name of target executables.
I guess I'll propose some improvement there at some point.
Received on Mon Oct 30 2023 - 00:12:41 CET