Re: [hackers] [dwm][PATCH] Avoid unsigned integer underflow in drw_text()

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Mon, 28 Oct 2024 20:57:13 +0100

On Mon, Oct 28, 2024 at 12:34:55AM +0000, Raymond Cole wrote:
> ---
> drw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drw.c b/drw.c
> index 344de61..c41e6af 100644
> --- a/drw.c
> +++ b/drw.c
> _AT_@ -248,6 +248,8 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lp
> } else {
> XSetForeground(drw->dpy, drw->gc, drw->scheme[invert ? ColFg : ColBg].pixel);
> XFillRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w, h);
> + if (w < lpad)
> + return x + w;
> d = XftDrawCreate(drw->dpy, drw->drawable,
> DefaultVisual(drw->dpy, drw->screen),
> DefaultColormap(drw->dpy, drw->screen));
> --
> 2.46.2
>
>

Thanks, it looks good, but I'll review it later.

In the meantime do you perhaps also have a bit more information about it? Does
this fix a bug or do you have a reproducable case?

This helps in reviewing it better/faster, etc.

-- 
Kind regards,
Hiltjo
Received on Mon Oct 28 2024 - 20:57:13 CET

This archive was generated by hypermail 2.3.0 : Mon Oct 28 2024 - 21:00:41 CET