Re: [wmii] wmii-3.6-rc1

first of all, sorry for my english.. :p

gcc 4.1.1 gives me these warnings:

bar.c: In function 'draw_bar':
bar.c:74: warning: value computed is not used
bar.c:85: warning: value computed is not used
key.c: In function 'match_keys':
key.c:161: warning: value computed is not used
view.c: In function 'update_views':
view.c:403: warning: value computed is not used
view.c:403: warning: value computed is not used

i looked at that lines, but i'm not a C guru and i've not found any error.

ola
mirco

ps: maybe now you can change CONFVERSION = 3.5 to CONFVERSION = 3.6 on config.mk..

On Wed, 07 Feb 2007 11:15:38 +0100
"Stefan Tibus" <sjti_AT_gmx.net> wrote:

> On Tue, 6 Feb 2007 11:18:34 -0500 Kris Maglione wrote:
> > On Tue, Feb 06, 2007 at 03:46:30PM +0100, Stefan Tibus wrote:
> > >wmii/draw.c contains a "return something" within a void function
> > >at line 65.
> >
> > Yes, it returns a call to itself, which is itself a void function.
>
> Well, it still is in todays repository, so you probably didn't
> consider this a bug. However, "return something" within a void
> function is not ANSI-C and the Sun Compiler here just says "no".
> It's a compatibility issue (like they appeared in libixp some
> time ago) and should be fixed. (And it's a non-sense construction
> in my eyes: returning some nothing within a function that is
> supposed to not return anything.)
>
> I have replaced draw.c line 61
> return loadfont(...);
> by
> loadfont(...); return;
> here. And in mouse.c line 334
> if (...)
> return do_managed_move(...);
> has to be
> if (...)
> { do_managed_move(...); return; }
> then (or something like that).
>
> Regards,
> Stefan
> --
> "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
> Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail?ac=OM.GX.GX003K11713T4783a
>
Received on Wed Feb 07 2007 - 11:36:40 UTC