Re: [wmii] wmii-3.6-rc1

From: Stefan Tibus <>
Date: Wed, 07 Feb 2007 11:15:38 +0100

On Tue, 6 Feb 2007 11:18:34 -0500 Kris Maglione wrote:
> On Tue, Feb 06, 2007 at 03:46:30PM +0100, Stefan Tibus wrote:
> >wmii/draw.c contains a "return something" within a void function
> >at line 65.
> Yes, it returns a call to itself, which is itself a void function.

Well, it still is in todays repository, so you probably didn't
consider this a bug. However, "return something" within a void
function is not ANSI-C and the Sun Compiler here just says "no".
It's a compatibility issue (like they appeared in libixp some
time ago) and should be fixed. (And it's a non-sense construction
in my eyes: returning some nothing within a function that is
supposed to not return anything.)

I have replaced draw.c line 61
    return loadfont(...);
    loadfont(...); return;
here. And in mouse.c line 334
    if (...)
        return do_managed_move(...);
has to be
    if (...)
        { do_managed_move(...); return; }
then (or something like that).


"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen:
Received on Wed Feb 07 2007 - 11:16:08 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 16:20:23 UTC