Re: [wmii] wmii-3.6-rc1

On Wed, Feb 07, 2007 at 11:15:38AM +0100, Stefan Tibus wrote:
>(And it's a non-sense construction in my eyes: returning some nothing
>within a function that is supposed to not return anything.)

Maybe so. The idea behind it was that the function's purpose is to be
taken over by another function. In this case, it's a recursive call, so
it seems quite idiomatic that it should return a call to itself. I'll
fix it for compatibility.

>I have replaced draw.c line 61
> return loadfont(...);
>by
> loadfont(...); return;

Ugh. I'm not as enamored with saving LOC as garbeam. That's just ugly.

>here. And in mouse.c line 334
> if (...)
> return do_managed_move(...);
>has to be
> if (...)
> { do_managed_move(...); return; }
>then (or something like that).

Again: ugh.
Received on Wed Feb 07 2007 - 18:18:59 UTC