Re: [dev] Fwd: st patches for more attrs

From: Roberto E. Vargas Caballero <>
Date: Tue, 24 Jun 2014 21:40:16 +0200

> impressive patch. I see that it probably has taken some time to write.

I totally agree. These patch serie seems very good.
> > The fast-blink support involves a bit of mucking about in the main
> > loop, and is a bit more debatable. I'm not entirely happy with it, but
> > it does separate things a bit. It also makes independent windows blink
> > synchronously, which makes me slightly less crazy.
> Tbh, I don't favor the fast-blink support, given blinking is not very
> common anymore. In fact, I struggle to find examples where it is being
> used at all.
> Thus, adding complexity to the program to support fast and slow
> blinking is in my opinion not a good choice.

I have a similar feeling, since the blinking time is different for
every processor, and in some cases the slow blink of ons terminal is similar
to the fast blink of another terminal, so I am not sure if it is a good
idea have two different speeds of use only one.

> I favor the INVISIBLE and STRUCK patches, because they are very simple.
> However, as before, I struggle to remember when I last saw struck text
> or text with the invisible attribute.

The struck attribute is used a lot of times, for example for getting
underlined words or for getting bold characters.


Roberto E. Vargas Caballero
Received on Tue Jun 24 2014 - 21:40:16 CEST

This archive was generated by hypermail 2.3.0 : Tue Jun 24 2014 - 21:48:07 CEST