[hackers] [surf] Simplify DOWNLOAD macro || Quentin Rameau

From: <git_AT_suckless.org>
Date: Mon, 8 May 2017 14:08:23 +0200 (CEST)

commit dca42648635b70f7d01adb8d9a53720a0c7909c1
Author: Quentin Rameau <quinq_AT_fifth.space>
AuthorDate: Thu May 4 18:24:33 2017 +0200
Commit: Quentin Rameau <quinq_AT_fifth.space>
CommitDate: Mon May 8 11:33:55 2017 +0200

    Simplify DOWNLOAD macro
    
    No need to spawn an extra sh.
    Use short flags for curl and quote operands.
    Replace sleep with read, let the user close the download window instead
    of waiting for an arbitrary time.
    Rename d to reflect what it's used for.
    Reorder sh positional arguments.
    Set $0 to a command name and shift other positional parameters to
    clarify the "sh -c" command.

diff --git a/config.def.h b/config.def.h
index a8a4a7b..f858f5a 100644
--- a/config.def.h
+++ b/config.def.h
_AT_@ -61,12 +61,11 @@ static WebKitFindOptions findopts = WEBKIT_FIND_OPTIONS_CASE_INSENSITIVE |
 }
 
 /* DOWNLOAD(URI, referer) */
-#define DOWNLOAD(d, r) { \
- .v = (const char *[]){ "/bin/sh", "-c", \
- "st -e /bin/sh -c \"curl -g -L -J -O --user-agent '$1'" \
- " --referer '$2' -b $3 -c $3 '$0';" \
- " sleep 5;\"", \
- d, useragent, r, cookiefile, NULL \
+#define DOWNLOAD(u, r) { \
+ .v = (const char *[]){ "st", "-e", "/bin/sh", "-c",\
+ "curl -g -L -J -O -A \"$1\" -b \"$2\" -c \"$2\"" \
+ " -e \"$3\" \"$4\"; read", \
+ "surf-download", useragent, cookiefile, r, u, NULL \
         } \
 }
 
Received on Mon May 08 2017 - 14:08:23 CEST