Re: [dev] [dwm] combining 'moveresize' with 'pertag'

On Fri, Oct 22, 2010 at 04:51:40PM +0200, Bert Münnich wrote:
> On Fri, Oct 22, 2010 at 04:37:31PM +0200, Claudio M. Alessi wrote:
> > I have no idea why the pertag patch moves the Monitor struct after the config.h
> > inclusion but I "feel" it's wrong. You should move the config.h at the end of
> > all structures definitions in order to ``allow nested code to access above
> > variables''. This way, everything will works properly out of the box.
> > That's all.
>
> Because it depends on LENGTH(tags) for some array members, and therefore
> needs config.h to be included before the Monitor struct definition...
>
Isn't it more natural to make moveresize into a patch to dwm.c?
Defining new functions in a configuration file shouldn't be done
too often I think. On the other hand moving the inclusion of
config.h around too much can be a headache as well, but it is
definitely rock-and-roll programming :-)
Received on Fri Oct 22 2010 - 22:06:23 CEST