The patch is already up on dwm.suckless.org/patches, including the issues it has. Do note that it _only_ crashes when there are 30+ clients in the _stack_. Monocle is not affected. I agree that a patch which introduces a crash (even with the unlikely case in which there's 30+ clients in the stack) should not be included by default, but perhaps someone here with a better knowledge in DWM can fix this another way.
> Date: Wed, 27 Mar 2013 11:03:28 -0400
> Subject: Re: [dev] [DWM] Patch: stack mfact
> From: vlaadbrain_AT_gmail.com
> To: dev_AT_suckless.org
>
> On Wed, Mar 27, 2013 at 10:41 AM, Raphael Proust <raphlalou_AT_gmail.com> wrote:
> > On Wed, Mar 27, 2013 at 1:17 PM, Jente Hidskes <jthidskes_AT_outlook.com> wrote:
> >> You're right - I should not have submitted the patch with a bug that would
> >> crash DWM. However, it was only with seven clients or more and as I rarely
> >> have more than 3 open at once, for me it wasn't that big of an issue. I have
> >> now fixed it, though.
> i sometimes switch to tag 0 when i'm looking for a windows that i've
> lost in the other tags somewhere. i tend to use Monocle where the
> number of terms/windows potentially goes beyond 7 etc... i think if
> it crashes dwm it isn't acceptable, i wouldn't want to encounter the
> crash anyway...
> >
> > You can make patches public by cloning the website repo
> > (http://git.suckless.org/sites/), adding a page for your patch and pushing
> > the changes.
> >
> and mention its weaknesses :p
>
Received on Wed Mar 27 2013 - 16:27:42 CET