Re: [dev] [sbase][patch] new expr, take 2 (and makefile improvements)

From: FRIGN <dev_AT_frign.de>
Date: Fri, 14 Nov 2014 10:58:20 +0100

On Thu, 13 Nov 2014 14:05:19 -0800
Evan Gates <evan.gates_AT_gmail.com> wrote:

>

Hey Evan,

attached you'll find a small refactorization of your code.
Please take a look at yylex() and try to comment the other
sections accordingly in a way people understand how it
works without having to go through each line.
There were small issues I found, for instance the lack of
VAL in the precs-table and exclusive if-clauses, but overall
the code was pretty clean.

A relatively complex program like expr really needs to be
explained better. Apart from that, I really like your
solution very much.

Cheers

FRIGN

-- 
FRIGN <dev_AT_frign.de>

Received on Fri Nov 14 2014 - 10:58:20 CET

This archive was generated by hypermail 2.3.0 : Fri Nov 14 2014 - 11:00:12 CET