Re: [dev] [sbase][find] find implementation

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Fri, 20 Feb 2015 10:19:25 +0000

On Thu, Feb 19, 2015 at 05:58:01PM -0800, Evan Gates wrote:
> I got sick of staring at the sed code and needed a break, so I wrote
> find. It is complete and POSIX compliant. The only FIXMEs that affect
> function are deciding what to do in a few error cases, and including
> nanoseconds when comparing file times.
>
> Other than that there a few things I've marked: 1 odd corner case
> (null byte as first character in a reply to -ok), 1 performance issue
> (strdup() and free() every filename for -exec + everytime), 2
> stylistic issues (code duplication between get_size_arg() and
> get_n_arg(), method of setting some global flags in parse()).
>
> For now I'll let other people take a look and switch back to sed.
>
> With my limited testing it works as expected. Please test it and
> report any bugs you find.

I've applied the patch, thanks! We still need a manpage
but that's trivial to do.

BTW we should avoid using bitfields altogether.

Cheers,
sin
Received on Fri Feb 20 2015 - 11:19:25 CET