Re: [dev] [sbase][patch] expr: comments, cleanup, style, etc.

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Thu, 26 Feb 2015 20:14:34 +0000

On Wed, Feb 25, 2015 at 08:20:18PM -0800, Evan Gates wrote:
> Went back and added some comments to expr where I thought it would
> benefit from extra explanation. Got rid of unnecessary allocations.
> Used utfnlen() with the match operator to add UTF-8 support. Made some
> changes for the style guide, then also rearranged a few things that
> IMO make the code more readable.
>
> I added a FIXME? comment. There is a strdup() that is never free()d.
> Is it worth keeping track of it at a global level just to free when
> we're done?

BTW, it would have been useful to include the text above in the commit
message :)

I don't think we should bother with that strdup() at all.
Received on Thu Feb 26 2015 - 21:14:34 CET