Re: [dev] [slock] PAM support

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Mon, 16 May 2016 15:52:57 -0700

On Mon, May 16, 2016 at 10:38:00PM +0200, Jan Christoph Ebersbach wrote:
> On Mon 16-05-2016 11:54 -0700, Eric Pruitt wrote:
> > Since PAM configurations typically enforce a delay before you can
> > reauthenticate after an incorrect password is entered, it would be
> > nice if there was another color to indicate that slock is waiting
> > for the PAM functions to return.
>
> As far as my test go, only if the password was entered incorrectly, PAM
> waits for a moment.

Yes, that's the scenario I described in my earlier message.

> In this case it would be nice to have a different color that indicates
> that the password has been handed to PAM. However, when the password
> is correct, PAM immediately returns. In this case, the screen would
> quickly change colors. Not sure if this desirable.

It's mildly annoying, but I don't consider it a deal breaker and think
the behavior is fine. The added complexity to work around it wouldn't be
worth it in my opinion. It can be made a little less jarring by
selecting a color that's in between the "password being typed" and
"password is incorrect" colors.

> Attached you find the patch that adds this feature. What do you think?

I think this patch works well.

Thank you,
Eric
Received on Tue May 17 2016 - 00:52:57 CEST