Re: [dwm] Coding styles

i too tired to comment on every rule

On 7/31/08, Anselm R Garbe <garbeam_AT_gmail.com> wrote:
> #define UINT unsigned int
>
> and that looks better to me. The problem with doing
>
> typedef unsigned int uint;
>
> is, that uint might be typedef'd already on some system, but maybe not on

yes, but one should not do the same with pointers or bad things will happen
http://c-faq.com/decl/typedefvsdefine.html

>> System specific calls
>
> Well not every platform supports POSIX, I'd really like to see a decent and
> simple portable OS abstraction library, which supports nearly all platforms,
> from Unix, Windows, WinCE to Symbian ;) That would make my current business
> life a lot easier.

+1
(main reason i started using highlevel language like python)

>> Dont include more than once
>> Use #ifndef _INCLUDE_FOO_H_ ; #define _INCLUDE_FOO_H_ to avoid including
>> the same file twice.
>
> I hate this rule. Good software should not need these hacks (or
> #pragma once as alternative).
> It is a sign that something is seriously broken, if you include a header
> file
> multiple times, and you should refactor it. This is no issue for dwm, but
> you
> will notice that all wmii-related projects aren't affected by this issue.

imho these include protectors are unavoidable if one writes lib code.
Received on Thu Jul 31 2008 - 16:08:48 UTC