Re: [dwm] regression in 5.0.1

On Sat, 06 Sep 2008, Anselm R Garbe wrote:

> 2008/9/6 bill lam <cbill.lam_AT_gmail.com>:
> > On Sat, 06 Sep 2008, Anselm R Garbe wrote:
> >> composition of all P* constants. Since PSize is never used in dwm's
> >> updatesize() algorithm this change doesn't fix or change anything in
> >> my opinion. If anyone sees an explanation why this change regarding
> >> the blog entry could fix something, please let me know.
> >
> > I might test but please show me additional lines that can print value
> > of size.flags to a log file.
>
> fprintf(stderr, "size.flags = %ul\n", size.flags);
>
> However, as I told, that won't give you more info, since PSize is the
> 4rth bit, and it is never checked and not included in any other
> P-definition we use such as PMinSize, PMaxSize, PAspect etc. I don't
> see why this could change anything...
>

I added that but have no idea where the error log resided.
Nevertheless, I simplified that line to

if(!XGetWMNormalHints(dpy, c->win, &size, &msize))return;

and the issue is also fxied. My theory is that if XGetWMNormalHints
fails then information returned in size is rubbish, and set that flag to
PSize can help to prevent incorrectly change anything.

-- 
regards,
====================================================
GPG key 1024D/4434BAB3 2008-08-24
gpg --keyserver subkeys.pgp.net --recv-keys 4434BAB3