Re: [dwm] [PATCH] small fix in propertynotify

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Sat, 14 Feb 2009 11:21:06 +0000

Thanks for these patches!

Kind regards,
Anselm

2009/2/12 Szabolcs Nagy <nszabolcs_AT_gmail.com>:
> On 2/12/09, Peter Hartlich <sgkkr_AT_hartlich.com> wrote:
>>> - if((ev->window == root) && (ev->atom = XA_WM_NAME))
>>> + if((ev->window == root) && (ev->atom == XA_WM_NAME))
>>
>> Why not remove the inner parens as well? Without them, gcc would have
>> noticed.
>
> yes, that's how i'd do (but in certain cases parents makes the code
> easier to read)
>
> now this is what i found in toggletag():
>
> if(!sel)
> return;
>
> mask = sel->tags ^ (arg->ui & TAGMASK);
> - if(sel && mask) {
> + if(mask) {
Received on Sat Feb 14 2009 - 11:21:06 UTC

This archive was generated by hypermail 2.2.0 : Sat Feb 14 2009 - 11:24:04 UTC