Re: [hackers] [st] [5 PATCHES] Code layout changes

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Wed, 8 Jul 2015 22:48:02 +0200

On Wed, Jul 8, 2015 at 8:45 PM, FRIGN <dev_AT_frign.de> wrote:
> Good evening everybody!
>
> I've taken a look at st today and made some changes that have proven to
> improve the code while working on sbase and ubase in the last few months.
>
> These patches imply layout and style changes in most places of the code,
> so before you grab your pitchforks and torches:
> The patches on the wiki are broken for git HEAD anyway. The next thing on
> my list is to go through _all_ patches on the wiki and make releases for
> 0.6, which has been tagged yesterday, and git HEAD preferrably after these
> patches have been merged.
>
> I know about the clause in the suckless style guide: The project's style
> has precedence. Nevertheless, I think it's only beneficial to have a
> consistent style across the multiple projects we have and most importantly
> across a single project in particular.
> I once read that suckless is indeed popular for some people because of our
> great "brain dead C dialect", thus I think it's a step in the right direction
> to make this dialect even more solid.

I agree. I think code consistency and clarity is very important aswell.

>
> Now is the best time to merge style changes like this, one day after the latest
> version has been tagged. This gives us (and especially me) enough time to take
> care of the wiki-patches.
>
> Please let me know what you think about it!
>

Nice work, this is indeed probably a good time to do these changes.

> Cheers
>

Kind regards,
Hiltjo
Received on Wed Jul 08 2015 - 22:48:02 CEST