Re: [hackers] [scc][PATCH] Add total compability to the Makefiles

From: Evan Gates <evan.gates_AT_gmail.com>
Date: Thu, 16 Jul 2015 11:36:11 -0700

On Thu, Jul 16, 2015 at 11:32 AM, Evan Gates <evan.gates_AT_gmail.com> wrote:
> A few notes on using sh.

Oh and one more I missed. You have

make $_AT_

which should be

make "$_AT_"

in order to maintain proper arguments. (In general there should never
be an unquoted expansion/substitution. There are a few acceptable uses
in POSIX sh as it doesn't support arrays.)

For example, notice how unquoted incorrectly expands to 3 parameters
instead of 2:

$ f() { printf '<%s>' $_AT_; echo; printf '<%s>' "$@"; echo; }
$ f foo 'bar baz'
<foo><bar><baz>
<foo><bar baz>

-emg
Received on Thu Jul 16 2015 - 20:36:11 CEST