Re: [hackers] [surf] Fix type of strictssl property. || Quentin Rameau

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Wed, 22 Jul 2015 21:40:10 +0200

Hi Quentin,

just wondering if this is actually ok.

Shouldn't it pass in a pointer, like:

diff --git a/surf.c b/surf.c
index 87c10ef..56df724 100644
--- a/surf.c
+++ b/surf.c
_AT_@ -1266,7 +1266,7 @@ setup(void) {
                g_error_free(error);
        }
        g_object_set(G_OBJECT(s), "tls-database", tlsdb, NULL);
- g_object_set(G_OBJECT(s), "ssl-strict", strictssl, NULL);
+ g_object_set(G_OBJECT(s), "ssl-strict", &strictssl, NULL);

        /* proxy */
        if((proxy = getenv("http_proxy")) && strcmp(proxy, "")) {

Best regards,
Anselm

On 13 July 2015 at 13:40, <git_AT_suckless.org> wrote:
> commit 9b6998e7ae06ef4df14f84a902c24c49c0968a1d
> Author: Quentin Rameau <quinq_AT_fifth.space>
> AuthorDate: Mon Jul 13 13:31:22 2015 +0200
> Commit: Quentin Rameau <quinq_AT_fifth.space>
> CommitDate: Mon Jul 13 13:31:22 2015 +0200
>
> Fix type of strictssl property.
>
> Thanks to Mark Edgar <medgar123_AT_gmail.com> for having spotted this.
>
> diff --git a/config.def.h b/config.def.h
> index a1ab211..1eb9566 100644
> --- a/config.def.h
> +++ b/config.def.h
> _AT_@ -19,7 +19,7 @@ static char *cookiefile = "~/.surf/cookies.txt";
> static char *cookiepolicies = "Aa_AT_"; /* A: accept all; a: accept nothing,
> _AT_: accept no third party */
> static char *cafile = "/etc/ssl/certs/ca-certificates.crt";
> -static char *strictssl = FALSE; /* Refuse untrusted SSL connections */
> +static Bool strictssl = FALSE; /* Refuse untrusted SSL connections */
> static time_t sessiontime = 3600;
>
> /* Webkit default features */
>
Received on Wed Jul 22 2015 - 21:40:10 CEST