Re: [hackers] [sbase] [PATCH] ls: Fix sorting of named entries

From: Quentin Rameau <quinq+hackers_AT_fifth.space>
Date: Sun, 1 Nov 2015 15:28:48 +0100

Hi Michael

> Previously, entcmp was being passed struct entry **, when it expected
> struct entry *.

No it's not, it is being passed a struct entry * by qsort() and expects a const void *.

> Many autoconf-generated configure scripts use `ls -t` to determine whether or
> not the system clock is behaving correctly. If they are sorted in the wrong
> order, it produces an error.

Thanks for reporting this issue, I've “fixed” that.

> ls.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/ls.c b/ls.c
> index c998fc7..c942930 100644

Obviously you didn't test your patch and just managed to break ls.
It doesn't even fix the issue you brought up.
The patch will be reverted and ls corrected.
Received on Sun Nov 01 2015 - 15:28:48 CET