Re: [hackers] [sbase] [PATCH] ls: Fix sorting of named entries

From: Quentin Rameau <quinq+hackers_AT_fifth.space>
Date: Sun, 1 Nov 2015 18:06:35 +0100

> > Previously, entcmp was being passed struct entry **, when it expected
> > struct entry *.
>
> No it's not, it is being passed a struct entry * by qsort() and expects a const void *.

I'm sorry, I reviewed the code and indeed I mixed two types of array in main() and in ls().

> Obviously you didn't test your patch and just managed to break ls.
> It doesn't even fix the issue you brought up.
> The patch will be reverted and ls corrected.

The patch you gave is still incorrect and I fixed the issue in another patch.
Thanks again for finding this issue.
Received on Sun Nov 01 2015 - 18:06:35 CET