Re: [hackers] [dwm] setfullscreen: don't process the property twice

From: Quentin Rameau <quinq+hackers_AT_fifth.space>
Date: Tue, 3 Nov 2015 00:03:09 +0100

> Heyho Quentin,

glop :)

> you should merge the conditions of the first two nested if statements and change
> the else if to hold the complete condition `(!fullscreen && c->isfullscreen)`.

Humm, why should I exactly?

if(fullscreen) {
        if(!c->isfullscreen)
} else if(c->isfullscreen)

against

if(fullscreen && !c->isfullscreen)
else if (!fullscreen && c->isfullscreen)

For me the second form is less understandable and has more unnecessary checks.
Received on Tue Nov 03 2015 - 00:03:09 CET