Re: [hackers] [dwm] setfullscreen: don't process the property twice

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Tue, 3 Nov 2015 00:10:39 +0100

Quentin Rameau wrote:
> Humm, why should I exactly?
>
> if(fullscreen) {
> if(!c->isfullscreen)
> } else if(c->isfullscreen)
>
> against
>
> if(fullscreen && !c->isfullscreen)
> else if (!fullscreen && c->isfullscreen)
>
> For me the second form is less understandable and has more unnecessary checks.

Heyho Quentin,

the second form saves one indentation level, two lines and allows to understand
the else if condition without having to read the if condition first.

--Markus
Received on Tue Nov 03 2015 - 00:10:39 CET