Re: [hackers] Re: [dmenu][PATCH] make prompt padding symmetric

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Thu, 7 Dec 2017 23:01:35 +0100

Alessandro Caputo wrote:
> At least on my two computers and with the fonts I tested, there's a problem
> with the padding of dmenu's prompt.
> I have attached two screenshots with simply an 'O' as prompt, and these are
> the pixel counts on each side of the 'O':
> - original: 18 left, 11 right
> - patched: 18 left, 19 right

Heyho Alessandro,

Indeed I can confirm this behavior. I guess the reason for the unsymmetrical
padding is the expectation of prompts ending with ':'. If you try this out, you
will see a balanced prompt. I don't have strong feelings about what the default
should be and would not even mind an additional condition for checking the last
character of the prompt: (prompt[strlen[prompt]-1] == ':' ? lrpad / 4 : 0)

I'll defer to community opinion on what the default should be.

--Markus
Received on Thu Dec 07 2017 - 23:01:35 CET