Re: [hackers] Re: [dmenu][PATCH] make prompt padding symmetric

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Thu, 7 Dec 2017 23:28:33 +0100

On Thu, Dec 07, 2017 at 10:51:17PM +0100, Alessandro Caputo wrote:
> Sorry, forgot to add some info.
> At least on my two computers and with the fonts I tested, there's a
> problem with the padding of dmenu's prompt.
> I have attached two screenshots with simply an 'O' as prompt, and these
> are the pixel counts on each side of the 'O':
> - original: 18 left, 11 right
> - patched: 18 left, 19 right
> Cheers,
> Alessandro
>
> On Thu, Dec 7, 2017 at 10:46 PM, Alessandro Caputo
> <[1]nonedisponibile_AT_gmail.com> wrote:
>
> ---
> dmenu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/dmenu.c b/dmenu.c
> index eae5685..4173c62 100644
> --- a/dmenu.c
> +++ b/dmenu.c
> _AT_@ -604,7 +604,7 @@ setup(void)
> y = topbar ? 0 : wa.height - mh;
> mw = wa.width;
> }
> - promptw = (prompt && *prompt) ? TEXTW(prompt) - lrpad / 4 :
> 0;
> + promptw = (prompt && *prompt) ? TEXTW(prompt) : 0;
> inputw = MIN(inputw, mw/3);
> match();
> --
> 2.15.1
>
> References
>
> 1. mailto:nonedisponibile_AT_gmail.com

Hi,

What is your config.h and the font and fallback fonts you use?
I can also reproduce this.
-- 
Kind regards,
Hiltjo
Received on Thu Dec 07 2017 - 23:28:33 CET

This archive was generated by hypermail 2.3.0 : Thu Dec 07 2017 - 23:36:24 CET