Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

From: NRK <nrk_AT_disroot.org>
Date: Mon, 2 May 2022 18:00:42 +0600

On Mon, May 02, 2022 at 01:37:26PM +0200, Hiltjo Posthuma wrote:
> LDFLAGS="-s" is practically the same as calling strip and stripping it.
>
> It is up to the distro package/ports maintainer to strip symbols (or not).
> This can be an additional packaging step.

Since many of the Makefiles have "-Os" by default, I thought it would
make sense to go all the way and strip by default as.

> I'd rather have it so the Makefile respects the system or package system CFLAGS
> and LDFLAGS by default. Then someone can do: make CFLAGS="-Os" LDFLAGS="-s"
> etc.

Currently, the dwm and dmenu doesn't exactly "respect the system
{C,CPP,LD}FLAGS". ST however does:

        # flags
        STCPPFLAGS = -DVERSION=\"$(VERSION)\" -D_XOPEN_SOURCE=600
        STCFLAGS = $(INCS) $(STCPPFLAGS) $(CPPFLAGS) $(CFLAGS)
        STLDFLAGS = $(LIBS) $(LDFLAGS)

Changing dwm and dmenu to do something similar to ST seems fine to me.

> As a off-topic side-note I think we removing config.mk and just having the
> Makefile is simpler too.

I personally find the separation of config.mk and Makefile an annoyance.
But at the same time, I've seen many (novice) users who prefer having a
config.mk.

- NRK
Received on Mon May 02 2022 - 14:00:42 CEST