Re: [hackers] [dwm] Redundant code in manage()?

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Tue, 29 Oct 2024 09:56:22 +0100

On Tue, Oct 29, 2024 at 02:25:13AM +0000, Raymond Cole wrote:
> In dwm's manage() function there is this line:
>
> XMoveResizeWindow(dpy, c->win, c->x + 2 * sw, c->y, c->w, c->h); /* some windows require this */
>
> It's hard to imagine what windows would require this. The commit history
> seems to leave no clue. Removing it hasn't caused any problem to me.
>
> My suggestion is to either add to the comment at least what "some windows"
> refer to, or remove it. Thank you!
>

For example In the past some Java applications could cause issues.
But I'm also not sure anymore exactly which applications would require it.

I agree some comments could be more clear, but at the same time its impossible
to document all cases/applications/toolkits without being too verbose.

Or maybe this comment is good enough.

-- 
Kind regards,
Hiltjo
Received on Tue Oct 29 2024 - 09:56:22 CET

This archive was generated by hypermail 2.3.0 : Tue Oct 29 2024 - 10:00:42 CET