Re: [hackers] [dwm] Redundant code in manage()?

From: Raymond Cole <rc_AT_wolog.xyz>
Date: Tue, 29 Oct 2024 13:22:46 +0000

On 24/10/29 09:56AM, Hiltjo Posthuma wrote:
> On Tue, Oct 29, 2024 at 02:25:13AM +0000, Raymond Cole wrote:
> > In dwm's manage() function there is this line:
> >
> > XMoveResizeWindow(dpy, c->win, c->x + 2 * sw, c->y, c->w, c->h); /* some windows require this */
> >
> > It's hard to imagine what windows would require this. The commit history
> > seems to leave no clue. Removing it hasn't caused any problem to me.
> >
> > My suggestion is to either add to the comment at least what "some windows"
> > refer to, or remove it. Thank you!
> >
>
> For example In the past some Java applications could cause issues.
> But I'm also not sure anymore exactly which applications would require it.
>
> I agree some comments could be more clear, but at the same time its impossible
> to document all cases/applications/toolkits without being too verbose.
>
> Or maybe this comment is good enough.
>
> --
> Kind regards,
> Hiltjo
>

The issue of some Java applications (some Java backend, actually) is
clearly documented in dwm's man page, if that's what you're refering to.

That line in manage() was added in 2008, since when dwm has been changed
quite a lot, so now that even you don't seem to have an explanation,
it's reasonable to assume that it's no longer useful.

That's nothing urgent, of course, so I completely understand if you
or other dwm developers don't care to investigate whether to remove
that line.
Received on Tue Oct 29 2024 - 14:22:46 CET