Re: [dev] [dwmstatus] dynamic infos

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Sat, 30 Mar 2013 17:37:54 +0100

-your indentation style is inconsistent, decide if you want to use tabs
or spaces, in context of the file: use tabs!
-return does not need braces.
-the /tmp/.dwmbuf.tmp could get filled up if a process is misconfigured
and spams /tmp/dwmbuf with lots of lines. You only retrieve one line per
second. Also showing a message for only a second is not enough to read it.

I think you should not use the second file /tmp/.dwmbuf.tmp and instead
display just the newest message from /tmp/dwmbuf and if there are no new
messages incoming, then display it for 5seconds or such.

Also have you thought about using a pipe instead of a file?

--Markus


Am 30.03.2013 17:05, schrieb Thuban:
> Sorry.
> Here are the file containing the function :
>
> http://dwm.suckless.org/dwmstatus/dynamic_info.c
>
> And in attachement, see tmpinfo() function.
>
> Regards,
>
>
> Le 16:42:33 le 30 mars 2013 , Markus Teich a ├ęcrit :
>> Am 30.03.2013 16:00, schrieb Thuban:
>>> As I'm not a good programmer, please correct and modify this function.
>>
>> Which function? attachement? ;)
>>
>> --Markus
>>
>
Received on Sat Mar 30 2013 - 17:37:54 CET

This archive was generated by hypermail 2.3.0 : Sat Mar 30 2013 - 17:48:05 CET