Re: [hackers] [surf][PATCH] Don't call setstyle with an empty path

From: Nick Hanley <nicholasjhanley_AT_gmail.com>
Date: Wed, 4 May 2022 23:38:59 -0400

On Wed, May 04, 2022 at 09:49:33AM +0200, Antonio Quartulli wrote:
> On 04/05/2022 00:18, Nick Hanley wrote:
> > On Tue, May 03, 2022 at 02:45:05PM -0400, fossy_AT_dnmx.org wrote:
> >> Just wondering - why not just do
> >> if (*getstyle(geturi(c)))
> >> setstyle(c, file);
> >
> > We need to pass the file path returned by getstyle to setstyle.
>
> An alternative would be to keep the original nested invocation and add a
> NULL check inside setstyle(). This would avoid adding an extra variable
> 'file'.

Is there a reason to avoid declaring a variable?
Received on Thu May 05 2022 - 05:38:59 CEST